Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy... -> Export to clipboard Dialog has no icon #6286

Closed
Siedlerchr opened this issue Apr 14, 2020 · 7 comments · Fixed by #6345
Closed

Copy... -> Export to clipboard Dialog has no icon #6286

Siedlerchr opened this issue Apr 14, 2020 · 7 comments · Fixed by #6345
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects

Comments

@Siedlerchr
Copy link
Member

Select an entry in the main table

  1. Right click -> Copy... -> Export to Clipboard

See that there is no icon. This results in the standard java icon shown in the task bar on windows

5.1 master
grafik

grafik

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. ui labels Apr 14, 2020
@Siedlerchr Siedlerchr added this to Normal priority in Bugs via automation Apr 14, 2020
@Siedlerchr Siedlerchr moved this from Normal priority to Low priority in Bugs Apr 14, 2020
@MootezSaaD
Copy link
Contributor

Hello, I would like to inquire if I could contribute by fixing this issue.

@Siedlerchr
Copy link
Member Author

@MootezSaaD Sure. The dialog should be called somewhere in org.jabref.gui.exporter.ExportToClipboardAction

@MootezSaaD
Copy link
Contributor

MootezSaaD commented Apr 25, 2020

Hello,
Sorry for the delay, I have tried to convert the ExportToClipboard to mvvm-pattern, this is the dialog

image

What I have done is I created ExportToClipboardViewModel and ExportToClipboardDialogView and ExportToClipboardAction now calls ExportToClipboardDialogView .
Is it fine to make a draft PR ?

@Siedlerchr
Copy link
Member Author

@MootezSaaD Oh wow, well, that would be a solution, but I fear that you have "overengineered" in this case. Maybe I also did not specify it better, but if you look into the JabRefDialogService class, there the dialog is created by using the standard ChoicedDialog component.

I think the solution would be just a one liner as in the ProgressDialog:
((Stage) progressDialog.getDialogPane().getScene().getWindow()).getIcons().add(IconTheme.getJabRefImageFX());

@MootezSaaD
Copy link
Contributor

Oh then that settles it, thank you @Siedlerchr

@Siedlerchr
Copy link
Member Author

See your other work not as wasted, but as a good training that enables you a good understanding of the Gui in jabref and hopefully you are interested in fixing other issues as well.

@MootezSaaD
Copy link
Contributor

Absolutely!
Thank you again for the assistance

Bugs automation moved this from Low priority to Closed Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Bugs
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants