Inconsistent file attachment naming

[alfureu]

JabRef 5.1--2020-08-03--586044a
Windows 10 10.0 amd64
Java 14.0.2

• Mandatory: I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behaviour:

1. Define your file naming convention in JabRef
2. Drag & Drop the file into the new entry -> it renames the file properly and moves it to the folder defined by the user
3. Remove the file from the entry
4. Use the plus button to add a file to the entry
5. The file is added, but the naming convention/file directory (both generic and user-specific) are ignored, i.e. it does not rename the file, and it does not move to the defined folder

This should not occur as it currently happens, as it brings in inconsistencies. If a generic/user-specific file location is defined, the user explicitly states where the files should be stored. I can imagine that a non-explicit definition can follow this behaviour, however, when there is an explicit path definition, it should be warranted at all times.

[Siedlerchr]

This needs some more thinking what the user expects. Downloads do respect the file directories and patterns already.
However, you can always do a right click on the file and execute the move/rename or you globally execute the cleanup action.

[alfureu]

Well, indeed, it is somewhat inconsistent. I have a naming convention set up, drag & drop respects it, search for fulltext, as well as download from link respects it, but manual add does not respect it.

Thanks for the manual rename option, I will try it next time.

[calixtus]

More thinkting needed? I'll put that on the jabcon label. 😉

[koppor]

We have primary and secondary behavior

Current behavior:

• button
  • primary: link
• drag'n'drop
  • primary: move and rename
  • secondary (pressing Shift): link

Behavior choices

• link
• copy
  • copy and rename
  • copy and keep original name
• move
  • move and rename
  • move and keep original name

Options:

• change behavior of button
• Second button
• Secondary behavior choosable at drop down (similar to Word saving options)
• Button with dropdown changing the button icon (and behaviour)
  • sub option: Remembering configration per library
  • sub option: Remembering configuration globally
• Button with accellarator offering different other options
  • 
  • Button remembering last choice
  • Button always offering "link and rename" as default
  • Button default configurable
• Change icon of button to link icon
  • Good, because user can still move and rename using the context menu

Options

• have drag'n'drop always consistent with button configuration
• have drag'n'drop initially consistent with button configuration
• drag'n'drop always having the same behavior
  • drag'n'drop has move and rename behavior
  • "consistent"
  • Good, because meets user expection
• drag'n'drop behaviour independent of button behaviour
  • Initial configration: consistent between drag and drop and button behavior
  • Two different "features"
• button having different behavior from drag'n'drop

Discussion:

• What is the context of the user?
• What is the generic experience of the user?

[github-actions]

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

• If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
• Provide further steps or information on how to reproduce this issue.
• Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
• If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!