Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XMP metadata has been written succesfully/failed to pdf #8276

Closed
ThiloteE opened this issue Nov 26, 2021 · 8 comments · Fixed by #8647
Closed

Add XMP metadata has been written succesfully/failed to pdf #8276

ThiloteE opened this issue Nov 26, 2021 · 8 comments · Fixed by #8647
Labels
external files good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Nov 26, 2021

Jabref version 5.3 is able to write XMP metadata to pdfs.

Problem:

  • I don't know if it has finished writing it.
  • I don't know if it was successful or has failed

Solution i would like:
Something that allows me to know.

  • I favour a loading timer/symbol/button/row or column that visibly fills up and that vanishes after the action has been completed. --> It provides both information, but also does not disturb the user.

Other solutions could be:

  • a popup --> disturbs workflow
  • a symbol that changes colour once. --> but if i want to write metadata again, then it would need to change colour again --> imperfect
  • Show information about what kind of metadata is currently attached to PDF(s) --> Workaround, not straightforward. Might require big changes to UI.
@ThiloteE
Copy link
Member Author

If i write XMP metadata to more than one file, there should NOT be a popup for every single file. 100 files, 100 popups is a big no no xD

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement labels Dec 5, 2021
@Siedlerchr Siedlerchr added this to Normal priority in Features & Enhancements via automation Dec 5, 2021
@ThiloteE
Copy link
Member Author

ThiloteE commented Dec 8, 2021

This is issue is only relevant for the functionality of writing metadata to a pdf-file from within the general tab in the entry editor.

@harshlancer
Copy link

Hey, I'm new to the open-source community can I contribute to this project I know how to code in Java.
Please tell me if I can contribute in any manner.

@ThiloteE
Copy link
Member Author

I apologize for not responding sooner!

Welcome to JabRef @harshlancer ! Check out our Contribution Guide https://devdocs.jabref.org/contributing

Meanwhile, it is possible to export XMP metadata via Tools > Write metadata to pdfs (F6) again.
image
I believe, back then, when I opened this issue this was not possible.

Writing metadata via F6 actually has a mechanism that shows if the write-process was successful or not. For this reason, the importance of solving this issue has diminished, but If you have taken an interest in this issue, sure, you are welcome :-)

Maybe it would be possible to re-use part of the code from the F6 functionality?
(Unfortunately I don't know where that part of the code would be and I am not deep into coding, so i am not much help assisting in that regard)

@ThiloteE
Copy link
Member Author

As a reminder: This issue is only relevant for what happens when clicking on the following button:
image

@vithlaithla
Copy link

Hi, I would like to contribute to the project and work on this issue.

@ThiloteE
Copy link
Member Author

ThiloteE commented Apr 5, 2022

@vithlaithla, hey sure. Do you know Antonio? This draft pull request already looks pretty good! Maybe you can talk to each other? If you prefer to work on a different issue alone, because this issue is too small for the both of you, check the labels for "good first issue" or if you are a student and need a project check out JabRefs candidate for university projects page.

@vithlaithla
Copy link

@ThiloteE hey thanks for the suggestions! I will look for other issues.

Features & Enhancements automation moved this from Normal priority to Done Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external files good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants