Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When prompting for restoring the backup, a diff should be shown #9066

Closed
koppor opened this issue Aug 16, 2022 · 4 comments · Fixed by #9311
Closed

When prompting for restoring the backup, a diff should be shown #9066

koppor opened this issue Aug 16, 2022 · 4 comments · Fixed by #9311

Comments

@koppor
Copy link
Member

koppor commented Aug 16, 2022

As user, one is not sure, what is the "backup" version of the ".bib" file. It could even be possible that the backup failed and JabRef destroys data when restoring from the backup (see #9063).

Example popup:

grafik

Thus, it would be nice if the dialog offered a button to show the diff. We should have that functionality at the "file changed on disk" notification.

Refs #6190

@HoussemNasri Could you have a look?

@koppor koppor added the ui label Aug 16, 2022
@ThiloteE ThiloteE added this to Normal priority in Features & Enhancements via automation Aug 20, 2022
@ThiloteE ThiloteE moved this from Normal priority to High priority in Features & Enhancements Aug 20, 2022
@Siedlerchr Siedlerchr added this to the v5.8 milestone Sep 15, 2022
@Siedlerchr
Copy link
Member

There needs to be warning as well:

WARNING: Restore from backup will overwrite your current library

@koppor
Copy link
Member Author

koppor commented Nov 1, 2022

The diff should also be shown at "Save before closing":

grafik

I just opened JabRef, changed a preference - and JabRef told me that there is a diff 🙈

@HoussemNasri
Copy link
Member

HoussemNasri commented Nov 1, 2022

I'm curious what preferences change the bib file? I see, the citation key patterns are encoded as metadata in the library file.

@koppor
Copy link
Member Author

koppor commented Nov 2, 2022

I'm curious what preferences change the bib file? I see, the citation key patterns are encoded as metadata in the library file.

However, they are "only" stored there if they are changed locally for the bib file. These local ones override the global ones (refs #8701). Thus, I assume nothing should be changed in the bib file if one changes the global preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Features & Enhancements
  
High priority
Development

Successfully merging a pull request may close this issue.

4 participants