Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to send using custom code when dropping files/folders #108

Closed
2 tasks done
Jacalz opened this issue Aug 23, 2023 · 3 comments
Closed
2 tasks done

Add a way to send using custom code when dropping files/folders #108

Jacalz opened this issue Aug 23, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Aug 23, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

The (upcoming) v3.5.0 release adds support for dropping file and folders onto the window but there is currently no way to use custom codes for the send.

Describe the solution you'd like to see.

We need to think of a good way to make it possible to specify using custom codes when dropping files. How to expose that is a good question.

@Jacalz Jacalz added the enhancement New feature or request label Aug 23, 2023
@Jacalz Jacalz added this to the v3.6.0 milestone Aug 23, 2023
@GalihFajar
Copy link

Hi @Jacalz I've made a draft PR to address this issue. Made it as a draft because it's still an idea (+ contains no new added tests). Please find the PR description to see how it works.

Thanks.

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 18, 2023

Thanks @GalihFajar. I appreciate you taking the time to contribute. I'll have a look later today :)

PS: You can skip the tests if you want. I haven't quite set up a good plan for how I want to handle tests for the backend and some code might have to be refactored to be more easily testable. It has been a longstanding plan of mine to make sure to add more tests.

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 22, 2023

Thanks @GalihFajar. This is now solved.

@Jacalz Jacalz closed this as completed Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants