Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing URIs as command line arguments #114

Open
2 tasks done
Jacalz opened this issue Sep 2, 2023 · 4 comments
Open
2 tasks done

Support passing URIs as command line arguments #114

Jacalz opened this issue Sep 2, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Sep 2, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

We only support passing files though the command-line at the moment. It would be good to also support passing (or switch to) use one or multiple uris.

Describe the solution you'd like to see.

We should add the proper code to handle being passed a uri and also then replace %F with %U in the desktop file on Linux and BSD.

@Jacalz Jacalz added the enhancement New feature or request label Sep 2, 2023
@Jacalz Jacalz added this to the v3.6.0 milestone Sep 2, 2023
@Jacalz Jacalz changed the title Support pass URIs as command line arguments Support passing URIs as command line arguments Oct 17, 2023
@GalihFajar
Copy link

Hi @Jacalz, I'd like to work on this. But first I need more clarifications on the expected solution to the problem. The expected solution that I'm thinking of is one of the followings:

  1. Add multiple file send option -> prompting user with an entry and let user to fill it with multiple file paths.
  2. Add an option which will allow user to select file, similar to what existing file selection. But since AFAIK Fyne doesn't yet support multiple files selection, the selection will reappear until user confirming that these selected files are ought to be sent.

I'm currently prototyping on the second solution, which I'd be happy to continue to work on (and submit the PR) if it's the solution you are expecting—though I'll be okay if the first one is selected 😄 .

Thanks!

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 26, 2023

Hi @GalihFajar. Thanks for looking into this. This issue is not necessarily as big as you might think. Sorry, I realise now that the description might not be entirely explaining everything.

We already support passing in files and folders as command line parameters. This is just about supporting that those file uris that begin with file://. I.e. changing the desktop file to use %U instead of %F (one or more uris instead of one or more file paths).

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 26, 2023

I don’t necessarily know if there is much to gain from implementing this to be honest. I’d recommend you to have a look at something else if you don’t mind ;)

@GalihFajar
Copy link

Ah sure, thanks for the confirmation. Will look into something else.

@Jacalz Jacalz modified the milestones: v3.6.0, Undecided Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants