Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build RichText segments without parsing markdown #117

Closed
2 tasks done
Jacalz opened this issue Sep 9, 2023 · 5 comments
Closed
2 tasks done

Build RichText segments without parsing markdown #117

Jacalz opened this issue Sep 9, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers performance Improve application performance
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Sep 9, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

For the QR-code and information dialog we are currently parsing markdown to build the text. We can set the required RichText regiments directly without having to parse a markdown string each time.

Describe the solution you'd like to see.

Set RichText segments directly. Hopefully it means that the markdown parser is dead code eliminates leading to smaller binaries (not sure how tightly coupled it is in Fyne or how smart the Go compiler is there).

@Jacalz Jacalz added good first issue Good for newcomers performance Improve application performance labels Sep 9, 2023
@Jacalz Jacalz added this to the v3.6.0 milestone Sep 9, 2023
@GalihFajar
Copy link

HI, is this issue available to be taken? Might need to explore first though, but I want to give it a try. Thanks!

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 16, 2023

It is indeed available to be taken. As long as no one is assigned it is fine. However, I haven't tested that it is better than parsing markdown.

@GalihFajar
Copy link

Appreciate it, could you help assign it to me?

@GalihFajar
Copy link

I've submitted the PR here.

I've built the code on the arm64 and it indeeds reduce the binaries smaller for about 2.3%.

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 17, 2023

Thanks for looking at it. I've assigned you to the issue and will try to review the PR later today :)

@Jacalz Jacalz closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers performance Improve application performance
Projects
None yet
Development

No branches or pull requests

2 participants