Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework transport/bridge to have less duplicated code between send/receive #128

Open
2 tasks done
Jacalz opened this issue Oct 30, 2023 · 0 comments
Open
2 tasks done
Labels
good first issue Good for newcomers refactoring Issues related to refactoring code.
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Oct 30, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

There is a bit of duplicated code between the list data for send and receive in internal/transport/bridge. We should try to improve cohesion by bringing duplicated code to shared functions.

Describe the solution you'd like to see.

Some kind of refactoring to avoid duplicated code. Maybe generics can be useful? I don't know.

@Jacalz Jacalz added good first issue Good for newcomers refactoring Issues related to refactoring code. labels Oct 30, 2023
@Jacalz Jacalz changed the title Rework transport/bridge to have less uplicated code between send/receive Rework transport/bridge to have less duplicated code between send/receive Oct 31, 2023
@Jacalz Jacalz added this to the v3.7.0 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactoring Issues related to refactoring code.
Projects
None yet
Development

No branches or pull requests

1 participant