Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the version from FyneApp.toml instead of hard coding #144

Open
2 tasks done
Jacalz opened this issue Mar 12, 2024 · 0 comments
Open
2 tasks done

Load the version from FyneApp.toml instead of hard coding #144

Jacalz opened this issue Mar 12, 2024 · 0 comments
Labels
bug Something isn't working infrastructure Issues related to project infrastructure. refactoring Issues related to refactoring code.

Comments

@Jacalz
Copy link
Owner

Jacalz commented Mar 12, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

Right now the current release version is hard-coded into the binary and the link to the release just naively points to a GitHub tag with the same name. This works well for our released binaries but the link will either be pointing to an older tag or a tag that do not yet exist depending on when the version gets updated.

Describe the solution you'd like to see.

Update the about page to try to use the version from FyneApp.toml if that has been bundled. If not, then we need to consider the two options:

  • Flatpak or Linux distributions that do not package using Fyne tooling: Show the correct version.
  • Development versions should somehow indicate that they are development versions.

It might be problematic to make those two work. Let's try to see what we can do.

@Jacalz Jacalz added bug Something isn't working infrastructure Issues related to project infrastructure. refactoring Issues related to refactoring code. labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Issues related to project infrastructure. refactoring Issues related to refactoring code.
Projects
None yet
Development

No branches or pull requests

1 participant