Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow building a version without 7Zip #56

Closed
personalizedrefrigerator opened this issue Sep 20, 2023 · 3 comments
Closed
Assignees

Comments

@personalizedrefrigerator
Copy link
Contributor

Joplin has an open issue related to including several default plugins with the application. One of these plugins would likely be Simple Backup, however, the 7Zip dependency seems to be causing MacOS signing issues (see laurent22/joplin#8040).

Would you be open to a pull request that

  1. Allows building a version of the plugin without 7Zip
  2. Uses the built-in CompressionStreams or Zlib APIs for compression when missing 7Zip
  3. Either
    a. Uses the built-in Node or SubtleCrypto APIs for encryption (may be difficult for users to decrypt), or
    b. Disables the encryption option when missing 7Zip.

Thank you for developing this plugin!!

@personalizedrefrigerator
Copy link
Contributor Author

personalizedrefrigerator commented Sep 20, 2023

Joplin seems to already depend on 7Zip, so it might make more sense to instead expose 7Zip to plugins in the way that fs-extra is exposed to plugins.

I'm closing this issue for now — a new issue can be created after the plugin API exposes 7zip to plugins.

Edit: 7Zip is an optional dependency of joplin-desktop — I'm not sure whether it's currently being bundled and signed with the MacOS app.

@personalizedrefrigerator
Copy link
Contributor Author

I'm reopening this issue as per comment.

@personalizedrefrigerator
Copy link
Contributor Author

Closing as pull request will bundle 7Zip directly with Joplin (and allow requireing it from plugins.

Thank you again for this very useful plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants