Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output reproducible #18

Closed
Jake-Shadle opened this issue Nov 23, 2021 · 1 comment · Fixed by #19
Closed

Make output reproducible #18

Jake-Shadle opened this issue Nov 23, 2021 · 1 comment · Fixed by #19
Labels
bug Something isn't working

Comments

@Jake-Shadle
Copy link
Owner

The SDK headers for the Desktop and Store variants contain many of the exact same files between them, so we only write one, but since this is running in parallel it's non-determinstic which one will get written, so we need to make it deterministic. It would also be a good idea to go ahead and actually verify that the files also have the same exact content as well. See this post for the original issue.

@Jake-Shadle Jake-Shadle added the bug Something isn't working label Nov 23, 2021
@K900
Copy link

K900 commented Nov 23, 2021

In addition to the threading issues, the deduplication algorithm uses a hashmap right now, and those are seeded independently on each run, so the output is non-deterministic even with one thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants