Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in #997 : IE8 still needs split test runs to prevent OOM issues. #1002

Closed
romainmenke opened this issue Feb 27, 2021 · 1 comment
Labels
library Relates to an Origami library

Comments

@romainmenke
Copy link
Collaborator

romainmenke commented Feb 27, 2021

@JakeChampion

I made a mistake in #997
This is why IE8 is failing more frequently now.
Maybe you can include the fix in one of the open PR's?

Otherwise I will open a new PR with the fix later.

fix :

https://github.com/Financial-Times/polyfill-library/blob/df5bab7c91d134ebdfae9edcf4c1626a1f2c3923/test/polyfills/remotetest.js#L167

-!modified.testEverything // no need to shard tests if only a subset is tested
+modified.testEverything // no need to shard tests if only a subset is tested
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Feb 27, 2021
@github-actions github-actions bot added the library Relates to an Origami library label Feb 27, 2021
@romainmenke
Copy link
Collaborator Author

Thank you!

Origami ✨ automation moved this from incoming to complete Feb 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Relates to an Origami library
Projects
None yet
Development

No branches or pull requests

1 participant