Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotate animation #51

Merged
merged 1 commit into from Jan 25, 2016
Merged

Add rotate animation #51

merged 1 commit into from Jan 25, 2016

Conversation

tbaranes
Copy link
Member

No description provided.

JakeLin added a commit that referenced this pull request Jan 25, 2016
@JakeLin JakeLin merged commit e927350 into IBAnimatable:master Jan 25, 2016
@JakeLin
Copy link
Member

JakeLin commented Jan 25, 2016

Cool @tbaranes I am thinking repeatCount can have Infinite or have .RotateForever in enum. That would be useful for lots of cases. But don't know to how support Infinite in @IBInspectable property.

@lexrus
Copy link
Member

lexrus commented Jan 26, 2016

How about let Infinite = -1?

@tbaranes
Copy link
Member Author

I though about this, but I conclude that the user will set infinite as the repeatCount. @lexrus suggestion is a bit hidden (if you don't now, hard to find), but maybe the nicest one solution?

@JakeLin
Copy link
Member

JakeLin commented Jan 26, 2016

Float does have Float.infinity, that's why I chose Float for repeatCount instead of Int. And repeatCount should be Int realistically. We can use Float.infinity in code. but can't do it in Interface Builder. I think let Infinite = -1 is not a bad idea for IB because we never have negative repeatCount.

On the other hand, I found out the documentation is also important for IBAnimatable project, if we have let Infinite = -1, we need to update the API document to describe this workaround.

@JakeLin
Copy link
Member

JakeLin commented Jan 26, 2016

The reason why I said documentation is also important because Interface Builder doesn't support validation for the value and the range. When I observed the others used IBAnimatable and the API document can help out the supported options and value range.

@tbaranes tbaranes mentioned this pull request Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants