fix to allow single sided borders #150
Conversation
| return | ||
| } | ||
|
|
||
| if borderWidth.isNaN || borderWidth <= 0 { | ||
| clearBorders() | ||
| return | ||
| } |
There was a problem hiding this comment.
Since the guard and the if are doing the thing, couldn't we merge them?
|
Nice catch 👍 I'm gonna let @JakeLin make the final review 👯 |
|
Good one, 👍 agree with @tbaranes , it is better to group them within one. Can we optimise that in this PR as well? Thanks. |
|
@seanwoodward thanks again for your PR, do you have time to make the last change according to @tbaranes 's comment? Or we can merge this PR then make the change after. We are about to release 2.2, 😉 thanks. |
|
I think we can merge it. We can handle that comment, or even do it directly in master since it's not a big change. |
|
@seanwoodward thanks again for your PR. @tbaranes working on release 2.2 now. |
No description provided.