Quick tile #114

mattprecious · 2016-06-03T15:21:39Z

So can't merge this yet for obvious preview-related reasons. Also, as you're already aware, targeting SDK 23+ means storage and draw-over-apps permissions aren't granted automatically. Opening the PR now anyway so there's no duplicate efforts.

Closes #92.

JakeWharton · 2016-06-03T15:23:11Z

telecine/src/main/java/com/jakewharton/telecine/TelecineTileService.java

+import android.service.quicksettings.Tile;
+import android.service.quicksettings.TileService;
+
+public class TelecineTileService extends TileService {


Ugh, where did my default class template go!

Using AS 2.2? http://b.android.com/211484

JakeWharton · 2016-06-03T15:53:57Z

telecine/src/main/AndroidManifest.xml

+
+    <service
+        android:icon="@drawable/ic_videocam_white_24dp"
+        android:label="@string/app_name"


This should probably be @string/launch_overlay to match the shortcut.

I'm also wondering if it would be beneficial to have a version of the launcher icon that can be used here.

Yeah I was originally planning on using a variation of the launcher icon but you already had this one for notifications so I went with that. The shortcut just uses "Launch". Is the icon enough context to indicate it's Telecine?

Maybe a new "Launch Telecine" string then

Done. Also found what might be a quick tiles bug. The system is caching the tile name for some period of time even after the app is updated. Have to remove and add it again.

JakeWharton · 2016-06-03T15:56:30Z

draw-over-apps permissions [isn't] granted automatically

This is only true of Android 6.0.0 but not 6.0.1+. I guess I'll need to design something for 6.0.0 where we tell you to go to Settings and enable it. Ugh.

mattprecious · 2016-06-03T15:58:51Z

Seems to be true again on N... This was crashing for me until I turned on the permission manually.

JakeWharton · 2016-06-03T16:03:14Z

Ah, yeah. The OS restriction is still there. The Play Store automatically grants the permission when you install through it.

mattprecious · 2016-06-03T16:03:57Z

Ah, right. Cool! One less issue to tackle.

jaredsburrows · 2016-06-03T21:46:11Z

👍

JakeWharton · 2016-06-15T19:56:10Z

@mattprecious update to 24 proper at your convenience. let's get this shipped!

mattprecious · 2016-06-15T20:16:58Z

Done. Targeting 24 means we have to ask for permissions.

JakeWharton · 2016-06-15T20:19:26Z

I may have asked this before, but do we need to target 24 for this? Or is compile 24 all that's needed?

jaredsburrows · 2016-06-15T20:20:46Z

Leave the target the same.
On Jun 15, 2016 1:19 PM, "Jake Wharton" notifications@github.com wrote:

I may have asked this before, but do we need to target 24 for this? Or is
compile 24 all that's needed?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABqMSFsc0T-wDLjrxuTlI7vndrAcJ24-ks5qMF5SgaJpZM4Itoyp
.

mattprecious · 2016-06-15T20:25:39Z

Wasn't needed. 22 works fine.

jaredsburrows · 2016-06-15T20:26:12Z

Yes.
On Jun 15, 2016 1:25 PM, "Matthew Precious" notifications@github.com
wrote:

Wasn't needed. 22 works fine.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABqMSP7C2X2ME-slM4KsJoycFkbKriP2ks5qMF_GgaJpZM4Itoyp
.

jaredsburrows · 2016-06-15T21:59:46Z

@mattprecious Your PR is still failing:

* What went wrong:
A problem occurred configuring project ':telecine'.
> failed to find target with hash string 'android-24' in: /usr/local/android-sdk

Update the TravisCI with this one:

language: android

jdk:
 - oraclejdk7
 - oraclejdk8

android:
  components:
    - tools
    - platform-tools
    - build-tools-24.0.0
    - android-24
    - extra-android-m2repository
    - extra-google-m2repository

script:
  - ./gradlew clean check -Dpre-dex=false

branches:
  except:
    - gh-pages

notifications:
  email: false

sudo: false

cache:
  directories:
    - $HOME/.gradle

mattprecious · 2016-06-16T15:55:32Z

Can't use JDK 7 anymore, apparently.

mattprecious · 2016-06-16T15:57:59Z

It's also yelling because the platform tools are too old. Is there a way to force travis to update?

jaredsburrows · 2016-06-16T15:58:40Z

@JakeWharton has not responded to my PR here(#115) but my suggestion for this repo would be to "ignore" jdk7. See here:https://github.com/JakeWharton/Telecine/pull/115/files#diff-354f30a63fb0907d4ad57269548329e3R7.

jaredsburrows · 2016-06-16T15:59:27Z

@mattprecious See here: The platforms tools are still in "preview" but there is a 24 RC1. The latest release is still 23.1. :(

JakeWharton · 2016-06-16T16:01:40Z

No the latest is 24. You just can't install it from the standalone SDK
manager.

IDGAF about JDK 7. It's EOL anyway.

On Thu, Jun 16, 2016 at 11:59 AM Jared Burrows notifications@github.com
wrote:

@mattprecious https://github.com/mattprecious See here: The platforms
tools are still in "preview" but there is a 24 RC1. The latest release is
still 23.1. :(
[image: screen shot 2016-06-15 at 4 21 25 pm]
https://cloud.githubusercontent.com/assets/1739848/16123620/8e4888f8-33a0-11e6-9a49-dbccffc46c51.png

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEEESoXdoxkK8NFe2gpoX-emDHTSC-Cks5qMXLhgaJpZM4Itoyp
.

jaredsburrows · 2016-06-16T16:02:02Z

@JakeWharton I'll update my PR as well.

JakeWharton · 2016-06-16T16:03:35Z

This is blocked by 2.2.0 being released then which can update the SDK
automatically for v24 of tools (and everything else).

On Thu, Jun 16, 2016 at 12:02 PM Jared Burrows notifications@github.com
wrote:

@JakeWharton https://github.com/JakeWharton I'll update my PR as well.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEEEf2ec-BgM5anr9psoLAMjF10KaYCks5qMXN6gaJpZM4Itoyp
.

jaredsburrows · 2016-06-17T20:23:03Z

@mattprecious Try this build again. Platform tools 24 is out. I am doing it here: https://github.com/jaredsburrows/android-gradle-java-app-template/blob/master/.travis.yml.

JakeWharton · 2016-06-19T07:00:28Z

You spelled launch "Lauch".

mattprecious · 2016-06-20T15:53:09Z

Just saving bytes.

jaredsburrows · 2016-06-20T15:54:09Z

@mattprecious Lol. Make a quick PR to fix?

mattprecious · 2016-06-20T15:59:34Z

It's already fixed. I believe Jake updated my branch before merging.

JakeWharton reviewed Jun 3, 2016
View reviewed changes

mattprecious force-pushed the mattp/quick-tile branch from a6b31e3 to ef4eb87 Compare June 3, 2016 15:28

JakeWharton reviewed Jun 3, 2016
View reviewed changes

mattprecious force-pushed the mattp/quick-tile branch from ef4eb87 to 9e54a40 Compare June 3, 2016 16:18

mattprecious force-pushed the mattp/quick-tile branch from 9e54a40 to b0d0397 Compare June 15, 2016 20:14

mattprecious force-pushed the mattp/quick-tile branch from b0d0397 to 0883597 Compare June 15, 2016 20:22

mattprecious force-pushed the mattp/quick-tile branch from 0883597 to 89c1f6e Compare June 16, 2016 15:47

mattprecious force-pushed the mattp/quick-tile branch from 89c1f6e to 323b887 Compare June 16, 2016 15:57

Quick tile

d8ea328

JakeWharton force-pushed the mattp/quick-tile branch from 323b887 to d8ea328 Compare June 19, 2016 06:52

jaredsburrows mentioned this pull request Jun 19, 2016

Support Android N's quick tile API #92

Closed

JakeWharton merged commit 111ba00 into master Jun 19, 2016

JakeWharton deleted the mattp/quick-tile branch June 19, 2016 07:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick tile #114

Quick tile #114

mattprecious commented Jun 3, 2016 •

edited by JakeWharton

JakeWharton Jun 3, 2016

mattprecious Jun 3, 2016

JakeWharton Jun 3, 2016

mattprecious Jun 3, 2016

JakeWharton Jun 3, 2016

mattprecious Jun 3, 2016

JakeWharton Jun 3, 2016

mattprecious Jun 3, 2016

JakeWharton commented Jun 3, 2016

mattprecious commented Jun 3, 2016

JakeWharton commented Jun 3, 2016

mattprecious commented Jun 3, 2016

jaredsburrows commented Jun 3, 2016

JakeWharton commented Jun 15, 2016

mattprecious commented Jun 15, 2016

JakeWharton commented Jun 15, 2016

jaredsburrows commented Jun 15, 2016

mattprecious commented Jun 15, 2016

jaredsburrows commented Jun 15, 2016

jaredsburrows commented Jun 15, 2016

mattprecious commented Jun 16, 2016

mattprecious commented Jun 16, 2016

jaredsburrows commented Jun 16, 2016

jaredsburrows commented Jun 16, 2016

JakeWharton commented Jun 16, 2016

jaredsburrows commented Jun 16, 2016

JakeWharton commented Jun 16, 2016

jaredsburrows commented Jun 17, 2016 •

edited

JakeWharton commented Jun 19, 2016

mattprecious commented Jun 20, 2016

jaredsburrows commented Jun 20, 2016

mattprecious commented Jun 20, 2016

Quick tile #114

Quick tile #114

Conversation

mattprecious commented Jun 3, 2016 • edited by JakeWharton

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JakeWharton commented Jun 3, 2016

mattprecious commented Jun 3, 2016

JakeWharton commented Jun 3, 2016

mattprecious commented Jun 3, 2016

jaredsburrows commented Jun 3, 2016

JakeWharton commented Jun 15, 2016

mattprecious commented Jun 15, 2016

JakeWharton commented Jun 15, 2016

jaredsburrows commented Jun 15, 2016

mattprecious commented Jun 15, 2016

jaredsburrows commented Jun 15, 2016

jaredsburrows commented Jun 15, 2016

mattprecious commented Jun 16, 2016

mattprecious commented Jun 16, 2016

jaredsburrows commented Jun 16, 2016

jaredsburrows commented Jun 16, 2016

JakeWharton commented Jun 16, 2016

jaredsburrows commented Jun 16, 2016

JakeWharton commented Jun 16, 2016

jaredsburrows commented Jun 17, 2016 • edited

JakeWharton commented Jun 19, 2016

mattprecious commented Jun 20, 2016

jaredsburrows commented Jun 20, 2016

mattprecious commented Jun 20, 2016

mattprecious commented Jun 3, 2016 •

edited by JakeWharton

jaredsburrows commented Jun 17, 2016 •

edited