Filter By Tag #43
Filter By Tag #43
Conversation
|
Doesn't the output look really odd since there's never anything on the left? |
|
It does, so I was going to add a switch to force the logging of the tag...thats when I found "--always-display-tags" ;). If you use the two switches together, the output does not look bad. But since, they both exist, I didn't force -t to imply "--always-display-tags" (thats a tiny change though) |
|
Is there a specific reason you aren't just using grep? |
|
Only because I didn't know that always-display-tags existed until I made the changes. As I said in the request, I don't know if its useful, but thought I would pass it along since I already did it. Feel free to discard the changes. |
|
Let me think on it a bit. Jake Wharton On Thu, Jan 9, 2014 at 9:13 PM, Adam Stroud notifications@github.comwrote:
|
|
No worries, I'm cool with whatever you want to do. |
|
I'm jumping in this conversation. The problem with grep is that it won't print everything if the log text is on multiple lines. I would love to be see something like --tag=MY_TAG |
|
@romainpiel you can try my fork of the pidcat https://github.com/tomrozb/pidcat You can specify tag or/and tag prefix if you like |
|
@tomrozb that's great I'll try it out, thanks! |
| @@ -40,6 +40,7 @@ | |||
| parser.add_argument('-s', '--serial', dest='device_serial', help='Device serial number (adb -s option)') | |||
| parser.add_argument('-d', '--device', dest='use_device', action='store_true', help='Use first device for log input (adb -d option).') | |||
| parser.add_argument('-e', '--emulator', dest='use_emulator', action='store_true', help='Use first emulator for log input (adb -e option).') | |||
| parser.add_argument('-t', '--tag', dest='tag', help='Filter output by specified tag') | |||
There was a problem hiding this comment.
This should have action='append' so it can be specified multiple times. Below should check with in (since it'll be a list) rather than equality.
There was a problem hiding this comment.
@JakeWharton I just updated the code to support a list of tags. Should I submit a new pull request?
There was a problem hiding this comment.
You can push to this PR's branch and it will update. Looks like you also need to rebase on the latest changes.
There was a problem hiding this comment.
The change was made in a new git repo. I deleted the old repo when I was doing some house cleaning. Do you know it that will that cause an issue?
There was a problem hiding this comment.
@JakeWharton I created a new PR (#68) that contains the changes from the new repo. If we still want the changes, we can either merge that one, or merge this one as-is and I can address the comments in another commit.
I added this code before I found the "--always-display-tags" switch which allows for useful grepping. I don't know if it's useful, but thought I would pass it along anyways.