Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement integration testing and CI/CD #7

Open
JakkuSakura opened this issue Mar 21, 2021 · 5 comments
Open

implement integration testing and CI/CD #7

JakkuSakura opened this issue Mar 21, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@JakkuSakura
Copy link
Owner

As suggested, there should be some kind of testing and CI/CD. My approach is to setup a kafka docker image and write a bunch of tests, like what kafkacat does.

For CI/CD, I have little experiences on them, but it should not be hard once we have docker-based tests.

@hbina
Copy link
Collaborator

hbina commented Mar 22, 2021

Why not use Github Actions?

@JakkuSakura JakkuSakura added the enhancement New feature or request label Mar 23, 2021
@neverchanje
Copy link
Collaborator

It looks like the github actions workflow didn't run well. I would like to draft a pr to fix it :)

@neverchanje
Copy link
Collaborator

Screen Shot 2022-04-14 at 6 37 33 PM

Screen Shot 2022-04-14 at 6 39 21 PM

@qiujiangkun Hi, please place a branch protection rule, and add tests into the checks. So that every pr would be required to pass the CI before merging.

@JakkuSakura
Copy link
Owner Author

image

I set up such rules

@neverchanje
Copy link
Collaborator

Thanks for your quick response! Let me fix the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants