New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No snippet return in the combo-box #8
Comments
I don't see MODX 2.3 yet.. But when I'm able to test it (I'm in the hospital right now), I will look at it as soon as possible |
Thanks a lot |
Not anymore.. My inflamed appendix is removed and I'll just be at home now.. Hope I can pick up work tomorrow :-) |
Quick & dirty re-factoring of the snippets/getlist processor (class based) that should fix the issue : require_once (MODX_CORE_PATH . 'model/modx/processors/element/snippet/getlist.class.php');
class cmSnippetGetListProcessor extends modSnippetGetListProcessor {
public function prepareQueryBeforeCount(xPDOQuery $c) {
$c->leftJoin('modCategory','Category');
$query = $this->getProperty('query');
if (!empty($query)) {
$c->where(array(
'name:LIKE' => '%'.$query.'%',
));
}
$id = $this->getProperty('id');
if (!empty($id)) {
$c->where(array(
'id' => $id,
));
}
return $c;
}
}
return 'cmSnippetGetListProcessor'; Get well soon Bert :) |
Okay thanks for that but MODX should be backwards compatible so I will dive into that because I don't have time to refactor all of the processors and I would it be the same for all |
My bad, it has nothing to do with the processor. ExtJS submit false as an integer, thus making the processor search for the snippet with id 0… By the way Bert, if you want me too i can handle the processor re-factoring (class based) but that will break the compatibility with Revo < 2.2 |
Cool! If you would like to do it and able to, trough github we can merge easily so that would save some time for me |
I'm not sure if it's just me or this issue has resurfaced. I'm on MODX 2.2.6-pl and installed cronManager 1.1 through the Package Manager. No snippets appear in the combo box, auto-completeon does not work and job always saves with snippet 'Undefined'. I looked at rtripault's fix but my version doesn't have a cronmanager/js folder to apply the code changes to. |
Please check if you got any request errors, in the console (F12 on Windows browsers like Chrome and Firefox+Firebug).. Probably some 500 server errors I think |
returning 200 doesn't say all. Can you check the error log? Maybe you can find some errors which are related to this, and can you click on a connector request to see what the response is of the combobox results? Above the screen is not from the combobox ;-) |
Should be fixed with 1.2.0 |
Hello
Using either Revo2.2 and Revo2.3 for both I entounter a problem with CronManager that does not list the snippets...
No error in the log ,(neither in modx log or apache log) ...
Hope you can do something I really need CronManager as prerequesite for use with GroupEletters
Thanks
Is there a version for revo2.3?
Cheers
The text was updated successfully, but these errors were encountered: