Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added custom widget for titleCompact and footerCompact #22

Closed
wants to merge 1 commit into from
Closed

[FEATURE] Added custom widget for titleCompact and footerCompact #22

wants to merge 1 commit into from

Conversation

BranislavMateas
Copy link
Contributor

Hey!

So playing with this package, I came to this problem, when I wanted to render different widgets for footer and title depending on the displayMode. I tried using providers, however, to make it work properly I needed to add addPostFrameCallback, which impacted performance (by rendering widgets late - I couldn't render it faster, as I can't call setState during the build phase), so I decided to make a new feature, that would solve this problem in a non-robust way - with adding titleCompact and footerCompact, which if not filled will not affect rendering of the footer/title. Hope you like it! (and merge it 馃榿)

Signed by Branislav Mate谩拧.

@Jamalianpour
Copy link
Owner

Hello and thanks,
But sorry it's not in my strategy. If anyone want to change tittle and footer in SideMenuDisplayMode.open or SideMenuDisplayMode.compact can use onDisplayModeChanged and then change his/her widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants