Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make Docker image customizable #673

Closed
lippertmarkus opened this issue Jun 22, 2018 · 4 comments
Closed

[Feature Request] Make Docker image customizable #673

lippertmarkus opened this issue Jun 22, 2018 · 4 comments
Labels
enhancement Issue suggests an enhancement

Comments

@lippertmarkus
Copy link

lippertmarkus commented Jun 22, 2018

First of all: Great work @James-Yu and @Arxisos in fully integrating my idea of #302 into this extension. This works great on every plattform.

Like another user also mentioned in #302 (comment), some may want to use a specific docker image including e.g. additional tools or a newer texlive version. Of course some could just re-tag a downloaded Docker image to tianon/latex to use it via Latex-Workshop, use the "manual way" I described in #302 or use @Arxisos shims (https://github.com/Arxisos/LaTex-Workshop-Docker) - but an option in the settings for configuring this maybe would be even more user friendly.

For the implementation I think the easiest way would be to set an environment variable before executing the scripts for *nix/Windows and using this environment variable in these scripts.

@James-Yu James-Yu added the enhancement Issue suggests an enhancement label Jun 22, 2018
@James-Yu
Copy link
Owner

It seems possible with ${@:2} replacing $@ and $1 as the docker image in the scripts. However I currently do not have access to computers with docker. It may rely on the community effort.

@James-Yu
Copy link
Owner

Will work on this feature. Maybe the docker name can be passed through envvar.

@James-Yu
Copy link
Owner

@lippertmarkus @lukasuni if possible please have a check on this commit and see if things work as expected.

@lippertmarkus
Copy link
Author

@James-Yu sorry for the delay - was a bit busy the last few weeks. Commit looks good to me and it also works like a charm, thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Issue suggests an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants