Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 #39

Closed
9 tasks done
JamesIves opened this issue Oct 16, 2019 · 3 comments
Closed
9 tasks done

Version 3.0.0 #39

JamesIves opened this issue Oct 16, 2019 · 3 comments
Assignees
Labels
feature request ✨ New feature or request planned 🕘 This feature is planned.
Milestone

Comments

@JamesIves
Copy link
Owner

JamesIves commented Oct 16, 2019

Version 3.0.0

I'm currently working on the next iteration of this action, here are the proposed changes.

  • The action will be re-written using the Action Toolkit API using TypeScript. The reason for this change is simply due to better testing, and because GitHub actions seem to be going more in this direction.
  • The action will no longer build projects. With the changes to the actions API it's much easier to simply add a build step before the action runs. It's a bit pointless to have a supported step in the process that is specifically for Node based projects. As it's more agnostic the idea is that it can now support any form of framework/env.
  • The action will utilize with instead of env and will now error straight off the bat if there's something missing.

Progress

I'm hoping to have most of this work wrapped up this week.

  • Re-write core functionality using the action using the actions/toolkit API.
  • Make it so the action uses the with case in the workflow file.
  • Add a .nojekyll flag.
  • Write the branch creation functionality using the actions/toolkit API.
  • Write unit tests.
  • Automate the deployment.
  • Create a releases/v2 branch so legacy versions can continue to work.
  • Add dev tooling so the code remains consistent.
  • Verify that the action works correctly with the proposed changes.
This was referenced Oct 16, 2019
@JamesIves JamesIves added this to the Version 3 milestone Oct 16, 2019
@JamesIves JamesIves added feature request ✨ New feature or request planned 🕘 This feature is planned. labels Oct 16, 2019
@JamesIves JamesIves self-assigned this Oct 16, 2019
@JamesIves
Copy link
Owner Author

Running into a few delays with this version release. I'm still working on it though.

@evamaxfield
Copy link

Just wanted to say thanks for both the original project and release and for planning to make this action multi-language supported. 👍

@JamesIves
Copy link
Owner Author

Version 3 is now released, please refer to the release notes for migration steps and details. Thanks for your patience everyone!

https://github.com/JamesIves/github-pages-deploy-action/releases/tag/3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ✨ New feature or request planned 🕘 This feature is planned.
Projects
None yet
Development

No branches or pull requests

2 participants