Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modes will start even when Terra Draw itself has not been started #12

Closed
JamesLMilner opened this issue Dec 23, 2022 · 1 comment
Closed

Modes will start even when Terra Draw itself has not been started #12

JamesLMilner opened this issue Dec 23, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JamesLMilner
Copy link
Owner

Currently when you use setMode, the mode will start even if Terra Draw itself has not been started:

https://github.com/JamesLMilner/terra-draw/blob/main/src/terra-draw.ts#L276

We should check to make sure Terra Draw has started first.
@JamesLMilner JamesLMilner added bug Something isn't working good first issue Good for newcomers labels Dec 23, 2022
@JamesLMilner
Copy link
Owner Author

Resolved in v0.0.1-alpha.14. Any non read only method (setMode, setModeStyles etc) will now throw an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesLMilner