Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashed Lines and Outline Styling #48

Open
JamesLMilner opened this issue Jul 1, 2023 · 1 comment
Open

Dashed Lines and Outline Styling #48

JamesLMilner opened this issue Jul 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@JamesLMilner
Copy link
Owner

This was originally raised in #38 but raising as a separate issue to more easily track it.

The purposed of this issue is to explore how viable it would be to support dash lines and outlines across mapping libraries. There is a somewhat philosophical question of if we we provide a fall back to a normal line if it is not supported and if we should have 'best effort' features in Terra Draw to allow support for more complex options.

@JamesLMilner JamesLMilner added the enhancement New feature or request label Jul 1, 2023
@JamesLMilner
Copy link
Owner Author

I started looking into this - I got this working with Leaflet, OpenLayers and Mapbox, but for MapLibre it is only possible to hardcode the dash array styling as a literal value (i.e. it cannot be driven by data/properties).

See maplibre/maplibre-gl-js#1235 for more details.

In theory we could push this forward without MapLibre support, but it feels weird to have one piece of styling functionality which does not work for one adapter. The other option is we do support MapLibre for dash lines but the value would be hardcoded to say [1, 1] and changing the styling property would not change it.

If people have thoughts on this I would be open to hearing them about what might be there preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant