Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates needed for QUnit core v1.15.0 #5

Closed
JamesMGreene opened this issue Aug 12, 2014 · 5 comments · Fixed by #7
Closed

Updates needed for QUnit core v1.15.0 #5

JamesMGreene opened this issue Aug 12, 2014 · 5 comments · Fixed by #7

Comments

@JamesMGreene
Copy link
Owner

Some unofficial public API methods are being removed in QUnit core v1.15.0. This plugin needs to be updated to account for such changes.

The undocumented but formerly public QUnit methods that have been removed in v1.15.0 are:

  • QUnit.id
  • QUnit.addEvent
  • QUnit.addClass
  • QUnit.hasClass
  • QUnit.removeClass
@FagnerMartinsBrack
Copy link

It would be nice to generate a new release with this fix.

@JamesMGreene
Copy link
Owner Author

@FagnerMartinsBrack: Good call, sorry about that.

@Krinkle @scottgonzalez: I've got ~5 little commits ready to push out as the next version (updates to devDependencies' versions, updated AUTHORS/mailmap, actual version bump, etc.). Could one of you kindly grant me maintainer rights to https://www.npmjs.org/package/qunit-composite? NPM username is "jamesmgreene". Thanks!

@scottgonzalez
Copy link
Contributor

@JamesMGreene done

@JamesMGreene
Copy link
Owner Author

Thanks, @scottgonzalez.

@FagnerMartinsBrack: Now published as v1.0.2. Thanks for your patience and the reminder.

@FagnerMartinsBrack
Copy link

Yeah thanks, I was using the master branch code.
Nevertheless it is always good to release ASAP such a breaking change like this one.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants