Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g-cli did not show any warnings or errors when using the deprecated (2.x) --timeout argument #153

Open
jimkring opened this issue Jul 17, 2023 · 1 comment
Milestone

Comments

@jimkring
Copy link
Contributor

I have a build that used the g-cli 2.x and was utilizing the --timeout argument, which has been renamed --connect-timeout. I was getting build errors that g-cli was timing out connecting and that seemed odd. I then did a g-cli --help and noticed there was no --timeout argument and it took me a few scans of the list of args to realize that it had been renamed.

Things that would have helped me (just a few ideas):

  • support the deprecated argument names as aliases to the new argument names
  • show a deprecation warning when using deprecated arguments
  • show a warning or error message when g-cli receives and unknown argument

Thanks!

@JamesMc86
Copy link
Owner

Hmm this should already be aliased, I'll added some testing in case the aliasing is broken and see if I can detect it and generate a warning

@JamesMc86 JamesMc86 added this to the 3.1 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants