Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe different error handling #114

Closed
apmcleod opened this issue May 9, 2020 · 0 comments
Closed

Maybe different error handling #114

apmcleod opened this issue May 9, 2020 · 0 comments
Labels
design This pertains to design decisions requires_discussion Either a large change or changes functionality - discuss/debate before implementation
Milestone
Dataset Public Re...

Comments

@apmcleod
Copy link
Collaborator

apmcleod commented May 9, 2020

midi_degradation_toolkit/mdtk/midi.py

Line 102 in 993e82a

warnings.warn(f'Error parsing midi file {midi_path}. Skipping.')

Arguably, this should throw a useful exception and be handled further up as a warning, if wanted. (For example, if I call this function with a non-MIDI file, it warns and returns None. Better, is to throw an exception that I'd have to explicitly catch above.
@apmcleod apmcleod added design This pertains to design decisions requires_discussion Either a large change or changes functionality - discuss/debate before implementation labels May 9, 2020
@apmcleod apmcleod added this to the Dataset Public Release milestone May 9, 2020
@JamesOwers JamesOwers mentioned this issue Aug 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design This pertains to design decisions requires_discussion Either a large change or changes functionality - discuss/debate before implementation
Projects
None yet
Milestone
Dataset Public Release
Development

No branches or pull requests
2 participants
@JamesOwers @apmcleod