Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beyond1 (Samsung Galaxy S10) and k63v2_64_bsp (Volla X) support #8

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

SchmueI
Copy link

@SchmueI SchmueI commented Dec 8, 2021

This Update includes the following devices:

  • Samsung Galaxy S10
  • Volla X
    Also it fixes a bug that the packages need to be updated via sudo apt update -y (See PR6)

@SchmueI SchmueI changed the title Add beyond1 (Samsung Galaxy S10) support Add beyond1 (Samsung Galaxy S10) and k63v2_64_bsp (Volla X) support Dec 9, 2021
@ghost
Copy link

ghost commented Mar 23, 2022

Hello. I struggled today to make this work on gx290 plus by creating a local diff with yggdrasilx.diff as name instead of your volla x code name and with the same content. I had to change from 3.9 to 6 the not expanded height of the top bar to see half of the icons from network and wifi. Maybe an align to bottom will solve that. Then I put instead of 64, 30 for top margin when expanded and for expanded top bar height I replaced the 3.9 with 2 that was added to 7. Thanks for this.

ps. if something goes wrong, the .cache/unity8-notch-hax folder must be deleted and only after that retried. I put the new diff in that folder by the way and that is how I made it work.

@JamiKettunen
Copy link
Owner

JamiKettunen commented Jun 30, 2022

@SchmueI So is it beyond1 or bayond1 (current diff filename)? I have a hard time believing this was tested properly. what does getprop ro.product.device and getprop ro.product.vendor.device say?

Also, if you can please:

  • Drop the commits not relevant to S10
  • Amend/fixup the remaining commits so that there's a single Add Samsung Galaxy S10 support or whatever commit in your branch

@JamiKettunen JamiKettunen marked this pull request as draft January 1, 2023 23:58
@JamiKettunen
Copy link
Owner

Marking as a draft due to my previous comment still not being acknowledged half a year later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants