Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional messages broken in 4.0.0 #103

Closed
britvik opened this issue Jan 10, 2019 · 4 comments
Closed

Optional messages broken in 4.0.0 #103

britvik opened this issue Jan 10, 2019 · 4 comments

Comments

@britvik
Copy link

britvik commented Jan 10, 2019

After updating version from 3.8.4 to 4.0.0 some of my tests started failing with ridiculous messages like "Expected true to be true" or "Expected false to be false".

I noticed this happened for toBeTrue and toBeFalse matchers where I used expectationFailOutput message. E.g. expect(someVar).toBeFalse('Some output message')

After a bit of debugging I noticed that expectationFailOutput message is passed to the matcher (instead of actual boolean value from the expect function).

After I reverted back to 3.8.4 everything started working again.
I'm using jasmine 3.3.0.

@JamieMason
Copy link
Owner

Thanks @britvik I will take a look.

@JamieMason JamieMason changed the title Broken matchers in 4.0.0 Optional messages broken in 4.0.0 Jan 12, 2019
@JamieMason
Copy link
Owner

Please try with 4.0.1 and reopen this issue if the problem persists, thanks.

@britvik
Copy link
Author

britvik commented Jan 15, 2019

It works in 4.0.1. Thank you @JamieMason

@JamieMason
Copy link
Owner

Great! you're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants