Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect(object).toBeSymbol() & toBeWellKnownSymbol() & toBeCustomSymbol() & toBeSymbolFor(string) #45

Closed
jrencz opened this issue Nov 13, 2015 · 2 comments

Comments

@jrencz
Copy link

jrencz commented Nov 13, 2015

It's related to #43 - Symbols may be matched as well

toBeWellKnownSymbol should pass well-known Symbols and toBeCustomSymbol (any hint on a better name?) should fail then a well-known symbol is passed.
Well-known symbols exist as properties on Symbol host object.

@jrencz jrencz changed the title expect(object).toBeSymbol() & expect(object).toBeWellKnownSymbol() & toBeCustomSymbol() & expect(object).toBeSymbolFor(string) expect(object).toBeSymbol() & toBeWellKnownSymbol() & toBeCustomSymbol() & toBeSymbolFor(string) Nov 13, 2015
@JamieMason
Copy link
Owner

Thanks @jrencz, I'd need a lot of input from you on this as I've not used Symbols.

@JamieMason
Copy link
Owner

Thanks again for raising this @jrencz but I've decided not to add matchers for Set etc. A new project such as jasmine-set-matchers could be useful to people though if you decide to take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants