Add support for lerna.json

[jantimon]

Usually people set different globs in the lerna.json.
For example the official lerna git repository:

https://github.com/lerna/lerna/blob/901e6d54a47151dfed3d6ed2912804b97d05c6b5/lerna.json#L2-L6

Would it be possible to use that data instead of a default glob?

[JamieMason]

Nice idea, thanks. I am away for a few days but maybe sketch up a proposal for the CLI options how you'd like it to work? Thanks

[jantimon]

All cli tools I know use their related configuration file even if no cli options are given.
E.g.
npm -> package.json
babel -> .babel.rc
lerna -> lerna.json
webpack -> webpack.config.js
typescript -> tsconfig.json

So imho the correct behaviour would be to pick up the settings from lerna.json by default.
Unfortunately that would be a breaking change for syncpack. 🤔

lerna-update-wizard (also a third party cli for lerna) is already following this approach:
https://github.com/Anifacted/lerna-update-wizard/blob/ea4958b3af2e3f1259543e9c69bdbe587f828bdf/src/index.js#L50

[JamieMason]

Sure 👍 just want to be clear we're thinking of the same thing before we go ahead.

[jantimon]

Thanks @JamieMason 👍

[JamieMason]

You're welcome Jan

[JamieMason]

It's taken me a while to work out the cause but I've realised this change is behind some slightly undesirable behaviour @jantimon. In my project I have "packages": ["packages/*"], in my lerna.json which means that when I run eg. syncpack format it only formats ./packages/* and not also ./package.json – so I have to redefine the --source patterns.

Would you mind please letting me know a bit more behind your usage of syncpack that led to this issue? I don't want to undo anything you were asking for when trying to improve my own workflow.

Thanks.

[jantimon]

Actually it would be nice to include the base ./package.json as well.

Usually my base package.json does not contain many dependencies but some linters

I use syncpack to reduce module duplication in lernas hoist mode.

[JamieMason]

Thanks a lot @jantimon, that should be a pretty easy fix 👍

[jantimon]

Thanks for your work! :)

[JamieMason]

Oh, this landed in 3.4.0 😊 https://github.com/JamieMason/syncpack/blob/master/CHANGELOG.md#340-2018-10-28