bug: Cannot read properties of undefined (reading 'concat') at Option.collect

[vonBrax]

Description

Commands that use the source option seem to be throwing this error:

TypeError: Cannot read properties of undefined (reading 'concat')
at Option.collect [as parseArg] (...node_modules\syncpack\dist\option.js:38:21)

Steps to reproduce:

npx  syncpack list-mismatches -s "packages/*/package.json"

env:

• syncpack: 9.0.0
• node: 19.4.0
• npm: 9.3.1
• os: windows 10

Suggested Solution

Apparently the default/initial value for the previous parameter of the collect function was removed.
It was here:

syncpack/src/option.ts

Lines 30 to 35 in fa21deb

	source: [
	'-s, --source [pattern]',
	'glob pattern for package.json files to read from',
	collect,
	[] as string[],
	],

And removed here:

syncpack/src/option.ts

Lines 18 to 22 in 2cd34fd

	source: [
	'-s, --source [pattern]',
	'glob pattern for package.json files to read from',
	collect,
	],

Issue can be fixed by adding back this line:

syncpack/src/option.ts

Line 34 in fa21deb

[] as string[],

[JamieMason]

Thanks @vonBrax I'll sort this today

[JamieMason]

Thanks for reporting, should be fixed in 9.0.2

[vonBrax]

Thank you for the awesome work and for the promptness in fixing the issue!