Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output semver/version groups in the order they're defined #120

Closed
JamieMason opened this issue Feb 16, 2023 · 1 comment
Closed

Output semver/version groups in the order they're defined #120

JamieMason opened this issue Feb 16, 2023 · 1 comment

Comments

@JamieMason
Copy link
Owner

Description

Every command that lists output has a .reverse() call – this is a hangover from a previous implementation before I recently refactored the code – looping in reverse just made it easier because it meant the first item could be known to be the default group.

This makes it harder to debug because the groups don't align with the order they're defined in config.

Suggested Solution

Remove the .reverse() calls from each command and update the expected numbers in the tests.

Help Needed

This should be an easy one, find and delete the calls, run yarn jest --watch --no-coverage, and fix the expected numbers in the log output in the failing tests.

@JamieMason JamieMason changed the title feat(groups): output semver/version groups in the order they're defined Output semver/version groups in the order they're defined Feb 16, 2023
@JamieMason
Copy link
Owner Author

Released in 9.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant