You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Every command that lists output has a .reverse() call – this is a hangover from a previous implementation before I recently refactored the code – looping in reverse just made it easier because it meant the first item could be known to be the default group.
This makes it harder to debug because the groups don't align with the order they're defined in config.
Suggested Solution
Remove the .reverse() calls from each command and update the expected numbers in the tests.
Help Needed
This should be an easy one, find and delete the calls, run yarn jest --watch --no-coverage, and fix the expected numbers in the log output in the failing tests.
The text was updated successfully, but these errors were encountered:
JamieMason
changed the title
feat(groups): output semver/version groups in the order they're defined
Output semver/version groups in the order they're defined
Feb 16, 2023
Description
Every command that lists output has a
.reverse()
call – this is a hangover from a previous implementation before I recently refactored the code – looping in reverse just made it easier because it meant the first item could be known to be the default group.This makes it harder to debug because the groups don't align with the order they're defined in config.
Suggested Solution
Remove the
.reverse()
calls from each command and update the expected numbers in the tests.Help Needed
This should be an easy one, find and delete the calls, run
yarn jest --watch --no-coverage
, and fix the expected numbers in the log output in the failing tests.The text was updated successfully, but these errors were encountered: