Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise ^6, >=5 etc as valid semver #122

Closed
JamieMason opened this issue Feb 18, 2023 · 1 comment
Closed

Recognise ^6, >=5 etc as valid semver #122

JamieMason opened this issue Feb 18, 2023 · 1 comment

Comments

@JamieMason
Copy link
Owner

Description

✘ npm has mismatched versions which syncpack cannot fix
  ^6 in engines.npm of package.json
  >=5 in engines.npm of packages/framework/fluid-framework/package.json
  ^5 in engines.npm of packages/framework/tinylicious-client/package.json

As a workaround, adding .0.0 to the end of those versions will cause syncpack to recognise them as semver.

Suggested Solution

  1. Add examples of these kinds of versions to /src/lib/is-semver.spec.ts
  2. Edit isSemver(version: unknown): boolean so the tests pass.
@JamieMason
Copy link
Owner Author

Released in 9.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant