Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make status codes easier to read #172

Closed
gtjamesa opened this issue Nov 23, 2023 · 6 comments
Closed

fix(cli): make status codes easier to read #172

gtjamesa opened this issue Nov 23, 2023 · 6 comments

Comments

@gtjamesa
Copy link

I'm just testing the 12-alpha to use the $LOCAL setting for my local monorepo packages. I love the new output layout, but the colours are pretty hard to read.

I'm using the crcandy zsh theme with the default Terminal on Linux Mint 21. The main terminal colours are coming from the system theme, but I switched to a few different dark themes and still had trouble viewing the [PinnedMismatch] text

image

@JamieMason
Copy link
Owner

Thanks @gtjamesa, I'll see about tweaking those. With the status codes being something I felt would be read the least often I think I set them to both grey AND dimmed. I did have a hunch this would come back and bite me but it looked pretty nice in my theme. Happy to make a change 👍

@gtjamesa
Copy link
Author

Great thanks! Yeah, I totally understand where you're coming from, and I'm sure someone will always have a problem with some colours. I've just been tweaking my terminal theme now, so it's more visible anyway

@JamieMason
Copy link
Owner

Great, thanks. In the future I could maybe move the colours out into config so they can be overridden, shouldn't be too hard.

@JamieMason JamieMason changed the title Syncpack 12 (alpha) colour feedback fix(cli): make status codes easier to read Dec 24, 2023
@JamieMason
Copy link
Owner

JamieMason commented Dec 24, 2023

See how it looks in 12.0.0 @gtjamesa, I've changed them to blue.

@gtjamesa
Copy link
Author

gtjamesa commented Jan 4, 2024

Sorry for the delay - I just updated it, and it looks great. Thank you!

@JamieMason
Copy link
Owner

You're welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants