Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(update): add repository url to the prompt #177

Closed
wants to merge 2 commits into from

Conversation

auto200
Copy link
Contributor

@auto200 auto200 commented Dec 11, 2023

Add formatted repository url to the update prompts
related issue: #178

image

@JamieMason
Copy link
Owner

I'll take a look at the issue in CI, it's from syncpack on codeclimate and nothing to do with your changes.

@JamieMason JamieMason changed the title prompt package repo link feat(update): add repository url to the prompt Dec 11, 2023
@auto200 auto200 marked this pull request as ready for review December 12, 2023 06:48
@auto200
Copy link
Contributor Author

auto200 commented Dec 12, 2023

Hey @JamieMason just letting you know that I implemented some "smart" 😆 parsing of the urls and the PR is ready for You to take a look

@JamieMason
Copy link
Owner

This is great @auto200, thanks a lot. By the way, had you used Effect previously or did you figure it out as you went?

@auto200
Copy link
Contributor Author

auto200 commented Dec 12, 2023

@JamieMason Glad you like it 😄 I did not use Effect before but gladly did not have to touch much Effect specific stuff. I had to look at some rxjs code in my past so pipes are kinda familiar to me 😄

The thing that wasn't clear for me was how do I actually run and test the modified code, I ended up with creating some dummy project and yarn linking the syncpack. It didn't occur to me until writing this, that I can run the built version on the syncpack's repo itself 🤣

@JamieMason
Copy link
Owner

Thanks @auto200, this is merged into the dev branch and will go out the next time I do a release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants