ENHANCE: abstracted endpoints to separate module, refactor 2 methods #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are no objections to this abstraction I can begin implementing this version of the endpoints throughout the rest of the library. |
This was referenced Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to abstract the endpoint dictionary into a separate module of functions that can be modified as the Robinhood API grows. I intend to contribute functionality for new options endpoints that I have discovered but the current dictionary would require several iterations of the same endpoint for the right functionality.
See get_popularity() and get_tickers_by_tag() for examples of how these new endpoints functions have been implemented in the main module. Also see the ach() function in the endpoints.py file to see how abstracting the endpoints can make this library more flexible, allowing the combination of 3 dictionary items into 1 function.