Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for sheet name/index checking #165

Closed
jmbarbone opened this issue May 8, 2022 · 0 comments · Fixed by #179
Closed

improvements for sheet name/index checking #165

jmbarbone opened this issue May 8, 2022 · 0 comments · Fixed by #179
Assignees

Comments

@jmbarbone
Copy link
Collaborator

add private and public methods to

  • self$validate_sheet() to make wb_validate_sheet() a wrapper
  • self$validate_new_sheet() to check against current sheets
  • private$get_sheet() to be more strict/possibly replace self$validate_sheet()
  • clean_worksheet_name() to wrap/replace replaceIllegalCharacters()

Meant to:

  • increase functionality of checks
  • restrict illegal characters (errors)
  • restrict name nchar levels (errors)
  • limit silent modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant