Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worksheet name with & #252

Closed
JanMarvin opened this issue Jun 27, 2022 · 2 comments
Closed

worksheet name with & #252

JanMarvin opened this issue Jun 27, 2022 · 2 comments
Labels
encoding 🔠 Encoding while reading or writing is disturbed internal 🔧

Comments

@JanMarvin
Copy link
Owner

In a sheet with & get_sheet_names() returns &. It's a named character and the names are correct. Maybe we should return only the names.

@JanMarvin JanMarvin added internal 🔧 encoding 🔠 Encoding while reading or writing is disturbed labels Jun 27, 2022
@JanMarvin JanMarvin added this to the v1.0.0 - CRAN release milestone Oct 13, 2022
@allmedia-nz

This comment was marked as off-topic.

@JanMarvin
Copy link
Owner Author

@allmedia-nz I marked your comment as off-topic for two reasons. a) It does not provide any new knowledge. Nothing has changed since June 2022 and wb |> wb_get_sheet_names() |> names() has always worked. b) if it works with openpyxl, then by all means use it. Nobody in the whole world forces you to use our open source solution. If one solution doesn't work, then maybe another one will. And just complaining ("This is very annoying...") is not helpful in any way.

But hey, I opened the issue, obviously I wasn't happy with it either. That's why I opened #724, which should solve the problem. But the function is used in several places internally, and the unescaped xml special characters caused unpleasant problems along the way, so it will have to wait until the next release, when hopefully we've had a chance for more extensive testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding 🔠 Encoding while reading or writing is disturbed internal 🔧
Projects
None yet
Development

No branches or pull requests

2 participants