Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fillMergedCells earlier in wb_to_df #324

Closed
JanMarvin opened this issue Sep 12, 2022 · 2 comments
Closed

fillMergedCells earlier in wb_to_df #324

JanMarvin opened this issue Sep 12, 2022 · 2 comments
Labels
bug 🐛 Something isn't working

Comments

@JanMarvin
Copy link
Owner

if start column is called with fill merged cells, filling can fail with "replacement has 0 elements ..." error. This could be prevented, if the filling is called earlier in the function.

@JanMarvin JanMarvin added the bug 🐛 Something isn't working label Sep 12, 2022
@JanMarvin
Copy link
Owner Author

Have to come up with an example. Seen it with SAS XLSX output from proc tabulate.

I assume the issue was that I wanted the last row of a merged column as variable name and wanted to start reading from that row.

The issue might have been that I hadn't imported the upper cells, so wb_to_df was unable to convert the content.

@JanMarvin
Copy link
Owner Author

Yet I'm not sure how to circumvent this. The solution might be an internal second wb_to_df call that reads the merged cells only and fills them. So that we always have valid cell content to insert and do not end up with unavailable content.

Though prior to solving this, I'd like to see my initial issue reproduced.

@JanMarvin JanMarvin linked a pull request Nov 26, 2022 that will close this issue
@JanMarvin JanMarvin removed a link to a pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant