Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial match of 'dxf' to 'dxfs' in read_xlsx #364

Closed
tentacles-from-outer-space opened this issue Oct 7, 2022 · 1 comment
Closed

partial match of 'dxf' to 'dxfs' in read_xlsx #364

tentacles-from-outer-space opened this issue Oct 7, 2022 · 1 comment

Comments

@tentacles-from-outer-space

It looks like typo in https://github.com/JanMarvin/openxlsx2/blob/79dc5903457f7e7bbe8afc8277323a12c7a01984/R/class-style_mgr.R

line 171 is:

dxfs <- self$styles$dxf

but suppose should be

dxfs <- self$styles$dxfs
library(openxlsx2)
#> Warning: package 'openxlsx2' was built under R version 4.1.3
packageVersion("openxlsx2")
#> [1] '0.3'
options(
  warn = 1L 
  ,warnPartialMatchDollar = TRUE
)

wb <- wb_workbook()
tmp_style <- create_dxfs_style(font_color = wb_colour(hex = "FF006100"))
wb$styles_mgr$add(tmp_style, "tmp_style")
wb$add_worksheet("test")
wb$add_data("test", cars)
wb$save(tmp_file <- tempfile(fileext = ".xlsx"))

a <- read_xlsx(tmp_file)
#> Warning: partial match of 'dxf' to 'dxfs'

Created on 2022-10-07 by the reprex package (v2.0.1)

@JanMarvin
Copy link
Owner

Looks like it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants