Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-closing spans are not supported ☣️⚠️ #8

Closed
n-sviridenko opened this issue Aug 9, 2019 · 2 comments · Fixed by #18
Closed

Self-closing spans are not supported ☣️⚠️ #8

n-sviridenko opened this issue Aug 9, 2019 · 2 comments · Fixed by #18

Comments

@n-sviridenko
Copy link

The library doesn't support html5 tags (e.g. self-closing span).

When parsing the following:

<span itemprop="price" content="139.90" />

foo

bar

It adds "foo ... bar" to the price attribute until it won't find a closing </span> tag.
@n-sviridenko
Copy link
Author

The issue is in the upstream repo.

@n-sviridenko
Copy link
Author

No, the issue is in this package as well. The context is here wikimedia/html-metadata#83

@n-sviridenko n-sviridenko reopened this Aug 9, 2019
This was referenced Aug 9, 2019
Closed
Open
@Janpot Janpot mentioned this issue May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for self closing tags Janpot/microdata-node
1 participant
@n-sviridenko