Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid jetty hot-deployment issue #1012

Merged
merged 7 commits into from
Mar 11, 2022
Merged

feat: avoid jetty hot-deployment issue #1012

merged 7 commits into from
Mar 11, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Mar 11, 2022

Description

  • Target issue Avoid hot-deployment issue for app running under Jetty server #1010
  • Implementation Details
    1. switch to archived .war instead of exploded directory under /opt/jans/jetty/$app/webapps
    2. set jetty.deploy.scanInterval=0 via command-line to disable hot-deployment
  • Misc.
    • customization on /opt/jans/jetty/$app/start.d/server.ini file is removed in favor of passing arguments when running Jetty
    • added missing additivity attribute for SCIM log4j2.xml file

@iromli iromli requested a review from moabu as a code owner March 11, 2022 10:25
@iromli iromli linked an issue Mar 11, 2022 that may be closed by this pull request
Avoid hot-deployment issue for app running under Jetty server #1010
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@moabu moabu merged commit a343215 into main Mar 11, 2022
@moabu moabu deleted the cn-avoid-hot-deploy branch March 11, 2022 11:05
This was referenced Mar 14, 2022
Merged
Merged
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request Mar 14, 2022
Merged
This was referenced May 18, 2022
Merged
Merged
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-auth-server comp-docker-jans-config-api comp-docker-jans-fido2 comp-docker-jans-scim kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid hot-deployment issue for app running under Jetty server
2 participants
@iromli @moabu