Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jans-linux-setup multivalued json mapping (ref: #1088) #1090

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

devrimyatar
Copy link
Contributor

As explained in #1088

@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-linux-setup Component affected by issue or PR labels Mar 21, 2022
Copy link
Contributor

@yurem yurem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to apply changes to https://github.com/JanssenProject/jans/blob/main/jans-linux-setup/jans_setup/schema/jans_schema.json ? We can try to add multivalued to these attributes in this schema file. After that we can remove customization from sql_data_types.json. In this fiel we should add changes which not conform to default setup rules.

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@devrimyatar
Copy link
Contributor Author

Can you try to apply changes to https://github.com/JanssenProject/jans/blob/main/jans-linux-setup/jans_setup/schema/jans_schema.json ? We can try to add multivalued to these attributes in this schema file. After that we can remove customization from sql_data_types.json. In this fiel we should add changes which not conform to default setup rules.

@yurem Implemented in this commit
13cdc0b

@yurem yurem enabled auto-merge (squash) March 22, 2022 18:36
@devrimyatar devrimyatar requested a review from yurem March 22, 2022 18:38
@duttarnab duttarnab requested a review from yurem March 23, 2022 06:02
@yurem yurem merged commit e3d9dbf into main Mar 23, 2022
@yurem yurem deleted the jans-linux-setup-multivalued-json-mapping branch March 23, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants