feat(jans-config-api): user-management endpoints #1167
Conversation
…ns-config-api-418
|
[jans-cli] Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| @POST | ||
| @ProtectedApi(scopes = { ApiAccessConstants.USER_WRITE_ACCESS }) | ||
| public Response createOpenIdConnect(@Valid User user) { |
There was a problem hiding this comment.
Not sure what does method name mean createOpenIdConnect, sounds like typo. createUser fits better.
There was a problem hiding this comment.
Sorry, rectified the same
|
|
||
| @GET | ||
| @ProtectedApi(scopes = { ApiAccessConstants.USER_READ_ACCESS }) | ||
| public Response getOpenIdConnectClients( |
There was a problem hiding this comment.
It's not openid clients, we are returning users. searchUsers or getUsers
There was a problem hiding this comment.
Sorry, rectified the same
| @QueryParam(value = ApiConstants.SORT_BY) String sortBy, | ||
| @QueryParam(value = ApiConstants.SORT_ORDER) String sortOrder) { | ||
| if (logger.isDebugEnabled()) { | ||
| logger.debug("User serach param - limit:{}, pattern:{}, startIndex:{}, sortBy:{}, sortOrder:{}", |
|
|
||
| @ApplicationScoped | ||
| @Named("userSrv") | ||
| public class UsrService extends UserService { |
There was a problem hiding this comment.
public class UserService extends io.jans.as.common.service.common.UserService will work too.
There was a problem hiding this comment.
it was public class UserService extends io.jans.as.common.service.common.UserService but when analyzed it locally it was giving sonar issue to change the name and hence i changed it to UsrService.
Will check in as suggested and lets see
There was a problem hiding this comment.
Strangely it is giving error locally but not reported by Github sonar check
|
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!
|
|
[Fido2 API] Kudos, SonarCloud Quality Gate passed!
|
|
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!
|
|
[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed! |
moabu
changed the title
@yuriyz request you to pls review and approve new endpoints for user management
Related issue 418
Endpoint: /jans-config-api/api/v1/user
Impacted modules:
1) jans-config-api: Endpoint related classes and swagger spec
2)jans-cli: endpoint spec changes