fix: update api-admin permissions from config api yaml #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devrimyatar
added
kind-bug
|
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed! |
pujavs
approved these changes
Apr 8, 2022
duttarnab
reviewed
Apr 8, 2022
| { | ||
| "role": "api-admin", | ||
| "permissions": [ | ||
| "https://jans.io/oauth/config/attributes.readonly", |
There was a problem hiding this comment.
Please add below permission to api-admin role mapping
https://jans.io/oauth/jans-auth-server/config/properties.readonly
There was a problem hiding this comment.
Please add below
permissiontoapi-adminrole mapping https://jans.io/oauth/jans-auth-server/config/properties.readonly
Don't worry about it. All scopes from config-api swagger yaml file is added to api-admin
yuriyz
approved these changes
Apr 8, 2022
This was referenced May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using static permissions for role based auth. Since it is static, developers have to update manually when they add new scope. With this PR scopes are updated form jans-config-api swagger yaml file.