Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust ownership and permission to avoid bloated images #1312

Merged
merged 1 commit into from
May 9, 2022
Merged

feat: adjust ownership and permission to avoid bloated images #1312

merged 1 commit into from
May 9, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 9, 2022

Description

The changeset fixes incorrect usage of ownership/permission (in docker context) as reported in #1307

Implementation Details

  • remove chown command as it increases the size of the image
  • replace chgroup -R command with chmod -R g=u to set directory ownership/permission
  • use chmod 664 command to set file permission

@iromli iromli requested a review from moabu as a code owner May 9, 2022 10:18
@iromli iromli linked an issue May 9, 2022 that may be closed by this pull request
feat(docker): review ownership and permission #1307
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@moabu
Copy link
Member

moabu commented May 9, 2022

reviewing....im going to run some tests before merging.

@moabu moabu merged commit d016682 into main May 9, 2022
@moabu moabu deleted the cn-owner-perm branch May 9, 2022 16:35
This was referenced May 18, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-auth-server comp-docker-jans-certmanager comp-docker-jans-client-api comp-docker-jans-config-api comp-docker-jans-configurator comp-docker-jans-fido2 comp-docker-jans-persistence-loader comp-docker-jans-scim kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(docker): review ownership and permission
3 participants
@iromli @moabu @mo-auto