Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forgot_password): update script according to jans specs #1637

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

christian-hawk
Copy link
Contributor

@christian-hawk christian-hawk commented Jun 29, 2022

Prepare


Description

Target issue

ref issues #1601 #1631

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@christian-hawk christian-hawk self-assigned this Jun 29, 2022
@mo-auto mo-auto added comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jun 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@christian-hawk
Copy link
Contributor Author

I haven't signed the commit, if this is a blocker please let me know.

@moabu
Copy link
Member

moabu commented Jul 5, 2022

I haven't signed the commit, if this is a blocker please let me know.

yes this is a blocker. All commits have to be signed. Your commit though looks signed

@moabu moabu added this to the 1.0.2 milestone Jul 20, 2022
@moabu moabu modified the milestones: 1.0.2, 1.0.3 Aug 30, 2022
@christian-hawk
Copy link
Contributor Author

@moabu @yuriyz @duttarnab @devrimyatar
I was requested to make this PR ready for review, just please notice the message I left in our internal communication channel #project_jans :

I created a draft PR that updates the scripts imports but not fix the related GitHub issues thou, as non of them are related to script functionality. They are related to Jans server startup (Initializing scripts) and cli authentication

So, this PR will NOT solve linked issues #1631 #1601 . I suggest UNLINKING the issues to avoid closing them by this merge.

Just making sure everybody is aware, making it ready for review right now.

@yuriyz yuriyz merged commit 6c6eeb3 into main Sep 26, 2022
@yuriyz yuriyz deleted the 1601_forgot_password_script branch September 26, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants