Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-client-api):minor observations PR1319 - typo transalation code-improvement #1806

Merged
merged 1 commit into from
Jul 15, 2022
Merged

fix(jans-client-api):minor observations PR1319 - typo transalation code-improvement #1806

merged 1 commit into from
Jul 15, 2022

Conversation

jmunozherbas
Copy link
Contributor

Minor observations PR 1319

Prepare

Description

Fixing minor observations after PR was merged, PR:1319

Target issue (PR comment)

#1319 (comment)

Implementation Details

Typo: "joinWithComa" -> "joinWithComma"
Translation of logs
Code improvement

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-client-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jul 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmunozherbas jmunozherbas marked this pull request as ready for review July 15, 2022 19:42
@yuriyz yuriyz merged commit 6df2e42 into main Jul 15, 2022
@yuriyz yuriyz deleted the fix-jans-client-api-minor-observations-pr-1319 branch July 15, 2022 20:12
@mo-auto mo-auto mentioned this pull request Aug 30, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@duttarnab duttarnab Awaiting requested review from duttarnab

Assignees
No one assigned
Labels
comp-jans-client-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmunozherbas @yuriyz @mo-auto