Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (jans-config-api) : incorrect response field type in swagger specs #2345

Closed
duttarnab opened this issue Sep 9, 2022 · 2 comments
Closed

fix (jans-config-api) : incorrect response field type in swagger specs #2345

duttarnab opened this issue Sep 9, 2022 · 2 comments
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@duttarnab
Copy link
Contributor

duttarnab commented Sep 9, 2022 •
edited
Loading

API: GET /jans-config-api/api/v1/jans-auth-server/config

Current behavior

In swagger specs, theauthorizationRequestCustomAllowedParameters field in the response is an array of string.
image

Expected behavior

The authorizationRequestCustomAllowedParameters field in response should be array of objects.

"authorizationRequestCustomAllowedParameters":[{"paramName":"customParam1","returnInResponse":false},{"paramName":"customParam3","returnInResponse":false},{"paramName":"customParam5","returnInResponse":true},{"paramName":"customParam4","returnInResponse":true},{"paramName":"customParam2","returnInResponse":false}]
@duttarnab duttarnab added the comp-jans-config-api Component affected by issue or PR label Sep 9, 2022
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Sep 9, 2022
@pujavs pujavs mentioned this issue Sep 9, 2022
Merged
5 tasks
@pujavs
Copy link
Contributor

pujavs commented Sep 9, 2022

fixed:
image

src.test.resources.feature.config.properties.properties.pdf

@pujavs
Copy link
Contributor

pujavs commented Sep 12, 2022

@duttarnab, change implemented via PR 2348, please verify

@pujavs pujavs closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duttarnab @pujavs @mo-auto