feat(jans-core): port Gluu ORM-based document store #2506 #2581
Conversation
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
| return false; | ||
| } | ||
| } catch (Exception e) { | ||
| log.error("Failed to rename to destination file '{}'", destinationDisplayName); |
There was a problem hiding this comment.
Something is wrong here. In case of exception, we got further in line 187 and return true even if it's not renamed.
Also we should log exception for easier troubleshooting.
| oxDocument.setOxModuleProperty(moduleList); | ||
| documentService.addOxDocument(oxDocument); | ||
| return true; | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
IOException is redundant because it has exactly same statements as super Exception.
| @DataEntry(sortBy = { "displayName" }) | ||
| @ObjectClass(value = "oxDocument") | ||
| @JsonInclude(Include.NON_NULL) | ||
| public class OxDocument extends Entry implements Serializable { |
There was a problem hiding this comment.
In jans we removed ox prefix. It's replace with jans prefix instead.
Lets rename OxDocument with just Document. It's inside document.store.service package so it's clear to what functionality it belongs. Object Class can be renamed oxDocument -> jansDocument. Please add changes in jans_schema.json. It seems to be missed in this PR.
| private List<String> oxModuleProperty; | ||
|
|
||
| @AttributeName | ||
| private String oxLevel; |
There was a problem hiding this comment.
This attribute is not present in jans. As well as other attributes refixed here as ox*. It must be changed. Please check existing schema in jans_schema.json. Lets re-use existing attributes.
| "names": [ | ||
| "jansDocument" | ||
| ], | ||
| "oid": "oxObjectClass", |
There was a problem hiding this comment.
jansObjClass instead of oxObjectClass?
| "jansLevel", | ||
| "jansRevision", | ||
| "jansEnabled", | ||
| "jansAlias" |
There was a problem hiding this comment.
It would be great to use spaces instead of tabs all over this PR. Otherwise you can see how github represents changes in weird way.
shekhar16
changed the title
feat(jans-core): port Gluu ORM-based document store #2506